Update TruffleHog workflow for better credential handling #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 30811ea in 33 seconds. Click for details.
- Reviewed
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/trufflehog.yml:16
- Draft comment:
The updated checkout step label now indicates credentials aren’t persisted, which clarifies intent. Ensure that the comment remains accurate if future changes occur. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. .github/workflows/trufflehog.yml:26
- Draft comment:
The git fetch command now includes the token in the URL to fetch the base commit. Verify that the token is properly masked in logs to avoid accidental exposure. Consider sourcing the token from an environment variable to enhance clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_gMd6T5miwVM9VBLM
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update TruffleHog workflow to improve credential handling by using GITHUB_TOKEN for fetching base commit and clarifying comments.
.github/workflows/trufflehog.yml, updated theCheckout PR HEADstep to clarify it is fork-safe and does not use credentials.Fetch base commitstep to useGITHUB_TOKENfor authentication when fetching the base commit.This description was created by
for 30811ea. You can customize this summary. It will automatically update as commits are pushed.